Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp_partition.h uses the esp_flash_t and should therefore include esp_flash.h (IDFGH-12919) #13879

Closed
wants to merge 1 commit into from
Closed

esp_partition.h uses the esp_flash_t and should therefore include esp_flash.h (IDFGH-12919) #13879

wants to merge 1 commit into from

Conversation

M-Bab
Copy link
Contributor

@M-Bab M-Bab commented May 29, 2024

Found by unit testing. esp_partition.h needs the type definition of esp_flash_t which is found in esp_flash.h.

This commit partially reverts c9c7573

@M-Bab
esp_partition.h uses the esp_flash_t and should therefore include esp…
ba8a6db 
…_flash.h

Found by unit testing. esp_partition.h needs the type definition of esp_flash_t which
is found in esp_flash.h.

This commit partially reverts c9c7573
@github-actions GitHub Actions
Copy link

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "esp_partition.h uses the esp_flash_t and should therefore include esp_flash.h":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ 
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello M-Bab, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against ba8a6db

@espressif-bot espressif-bot added the Status: Opened Issue is new label May 29, 2024
@github-actions github-actions bot changed the title esp_partition.h uses the esp_flash_t and should therefore include esp_flash.h esp_partition.h uses the esp_flash_t and should therefore include esp_flash.h (IDFGH-12919) May 29, 2024
@M-Bab
Copy link
Contributor Author

M-Bab commented Jun 3, 2024

Okay that may break the regular build. Not good 🤔

@M-Bab M-Bab closed this Jul 3, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Won't Do This will not be worked on and removed Status: Opened Issue is new labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-Bab @espressif-bot